zhijiangW commented on a change in pull request #8455:
[FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in
credit-based network mode
URL: https://github.com/apache/flink/pull/8455#discussion_r288853879
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
##########
@@ -75,6 +76,9 @@
private static final String METRIC_OUTPUT_POOL_USAGE = "outPoolUsage";
private static final String METRIC_INPUT_QUEUE_LENGTH =
"inputQueueLength";
private static final String METRIC_INPUT_POOL_USAGE = "inPoolUsage";
+ private static final String
METRIC_CREDIT_BASED_FLOATING_BUFFER_POOL_USAGE = "floatingBufferUsage";
Review comment:
I think it is better to not add the keywords `CREDIT-BASED` here, because
after we remove the deprecated network codes finally, it is no need to
emphasize this term any more. The terms of exclusive/floating already indicate
that.
Also it should be consistent between variable name and value, like
`METRIC_FLOATING_BUFFERS_USAGE = "floatingBuffersUsage"`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
