[
https://issues.apache.org/jira/browse/FLINK-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14738909#comment-14738909
]
ASF GitHub Bot commented on FLINK-2654:
---------------------------------------
Github user bderak commented on a diff in the pull request:
https://github.com/apache/flink/pull/1116#discussion_r39173028
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java ---
@@ -124,6 +138,13 @@ else if(arg.startsWith("-")) {
return fromMap(map);
}
+ /**
+ * Returns {@link ParameterTool} for the given properties file
+ *
--- End diff --
ouch, my IDEA defaults to 4 space indentation.
I ll fix it now..
> Add JavaDoc to ParameterTool class
> ----------------------------------
>
> Key: FLINK-2654
> URL: https://issues.apache.org/jira/browse/FLINK-2654
> Project: Flink
> Issue Type: Improvement
> Reporter: Behrouz Derakhshan
> Priority: Minor
>
> ParameterTool class is missing JavaDocs
> The tool is already being used, and the plan is to use it in all of the
> example codes. We should add JavaDocs before start using it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
