Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1098#discussion_r39174305
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/datastream/DataStream.java
---
@@ -1004,10 +989,38 @@ public ExecutionConfig getExecutionConfig() {
@SuppressWarnings("unchecked")
public <X extends Tuple> DataStreamSink<T> writeAsCsv(String path,
WriteMode writeMode,
long millis) {
+ return writeAsCsv(path, writeMode, millis,
CsvOutputFormat.DEFAULT_LINE_DELIMITER,
CsvOutputFormat.DEFAULT_FIELD_DELIMITER);
+ }
+
+ /**
+ * Writes a DataStream to the file specified by path in csv format. The
+ * writing is performed periodically, in every millis milliseconds.
+ *
+ * <p>
+ * For every field of an element of the DataStream the result of {@link
Object#toString()}
+ * is written. This method can only be used on data streams of tuples.
+ *
+ * @param path
+ * the path pointing to the location the text file is
written to
+ * @param writeMode
+ * Controls the behavior for existing files. Options are
+ * NO_OVERWRITE and OVERWRITE.
+ * @param millis
--- End diff --
Please add both delimiter parameters to the JavaDocs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
