[
https://issues.apache.org/jira/browse/FLINK-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14738929#comment-14738929
]
ASF GitHub Bot commented on FLINK-2622:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1098#discussion_r39174305
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/datastream/DataStream.java
---
@@ -1004,10 +989,38 @@ public ExecutionConfig getExecutionConfig() {
@SuppressWarnings("unchecked")
public <X extends Tuple> DataStreamSink<T> writeAsCsv(String path,
WriteMode writeMode,
long millis) {
+ return writeAsCsv(path, writeMode, millis,
CsvOutputFormat.DEFAULT_LINE_DELIMITER,
CsvOutputFormat.DEFAULT_FIELD_DELIMITER);
+ }
+
+ /**
+ * Writes a DataStream to the file specified by path in csv format. The
+ * writing is performed periodically, in every millis milliseconds.
+ *
+ * <p>
+ * For every field of an element of the DataStream the result of {@link
Object#toString()}
+ * is written. This method can only be used on data streams of tuples.
+ *
+ * @param path
+ * the path pointing to the location the text file is
written to
+ * @param writeMode
+ * Controls the behavior for existing files. Options are
+ * NO_OVERWRITE and OVERWRITE.
+ * @param millis
--- End diff --
Please add both delimiter parameters to the JavaDocs.
> Scala DataStream API does not have writeAsText method which supports WriteMode
> ------------------------------------------------------------------------------
>
> Key: FLINK-2622
> URL: https://issues.apache.org/jira/browse/FLINK-2622
> Project: Flink
> Issue Type: Bug
> Components: Scala API, Streaming
> Reporter: Till Rohrmann
>
> The Scala DataStream API, unlike the Java DataStream API, does not support a
> {{writeAsText}} method which takes the {{WriteMode}} as a parameter. In order
> to make the two APIs consistent, it should be added to the Scala DataStream
> API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
