azagrebin commented on a change in pull request #8518: [FLINK-12564][network] 
Remove getBufferProvider method from ResultPartitionWriter
URL: https://github.com/apache/flink/pull/8518#discussion_r288956472
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartition.java
 ##########
 @@ -188,7 +190,7 @@ public int getNumberOfSubpartitions() {
                return subpartitions.length;
        }
 
-       @Override
+       @VisibleForTesting
        public BufferProvider getBufferProvider() {
 
 Review comment:
   we can actually remove it and use `getBufferPool` in `LocalInputChannelTest` 
where it is used.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to