tzulitai commented on a change in pull request #8570: [FLINK-12688] [state]
Make serializer lazy initialization thread safe in StateDescriptor
URL: https://github.com/apache/flink/pull/8570#discussion_r289263899
##########
File path:
flink-core/src/test/java/org/apache/flink/api/common/state/StateDescriptorTest.java
##########
@@ -224,6 +253,15 @@ public void testEqualsSameNameAndTypeDifferentClass()
throws Exception {
public Type getType() {
return Type.VALUE;
}
+
+ public TypeSerializer<T> getOriginalSerializer() {
Review comment:
This would not be necessary if we move this to the `StateDescriptor` class
itself, and make the atomic reference field private. IMO, this is safer (please
see my other comment above).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
