GJL commented on a change in pull request #7987: [FLINK-11820][serialization]
SimpleStringSchema handle message record which value is null
URL: https://github.com/apache/flink/pull/7987#discussion_r289291508
##########
File path:
flink-core/src/test/java/org/apache/flink/api/common/serialization/SimpleStringSchemaTest.java
##########
@@ -50,4 +50,12 @@ public void testSerializability() throws Exception {
assertEquals(schema.getCharset(), copy.getCharset());
}
+
+ @Test
+ public void testDeserializeWithNullValue() throws Exception {
+ final SimpleStringSchema schema = new SimpleStringSchema();
+ final String value = schema.deserialize(null);
+
+ assertEquals(value, null);
Review comment:
Expected value is always the first argument in junit. Also consider using
`assertNull`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
