[ 
https://issues.apache.org/jira/browse/FLINK-12571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Yao closed FLINK-12571.
----------------------------
    Resolution: Fixed

1.9: bfd53e9d3f5a221bca8ca82e5f2ab5399d3fa0fd

> Make NetworkEnvironment#start() return the binded data port
> -----------------------------------------------------------
>
>                 Key: FLINK-12571
>                 URL: https://issues.apache.org/jira/browse/FLINK-12571
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Runtime / Network
>            Reporter: zhijiang
>            Assignee: zhijiang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.9.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently `NetworkEnvironment#getConnectionManager()` is mainly used for 
> `TaskManagerServices` for getting binded data port from 
> `NettyConnectionManager`. Considering the `ConnectionManager` as an internal 
> component of `NetworkEnvironment`, it should not be exposed for outsides. For 
> other ShuffleService implementations, it might have no `ConnectionManager` at 
> all.
> We could make `ShuffleService#start()` return the binded data port to replace 
> the `getConnectionManager`. For the `LocalConnectionManager` or other shuffle 
> service implementations which have no binded data port, it could return a 
> simple default value and it would have no harm.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to