[
https://issues.apache.org/jira/browse/FLINK-12564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-12564.
------------------------------------
Resolution: Fixed
master: c53c446486d58e3db149a9ea6fe1984227e415b2
> Remove getBufferProvider method from ResultPartitionWriter interface
> --------------------------------------------------------------------
>
> Key: FLINK-12564
> URL: https://issues.apache.org/jira/browse/FLINK-12564
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / Network
> Reporter: zhijiang
> Assignee: zhijiang
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently `ResultPartitionWriter#getBufferProvider` is used for requesting
> `BufferBuilder` in `RecordWriter`, then the `BufferConsumer` created from
> `BufferBuilder` is added into `ResultPartitionWriter` via `addBufferConsumer`
> method.
> We could merge these two methods in `ResultPartitionWriter` in order not to
> expose `getBufferProvider`. `ResultPartitionWriter` could internally request
> `BufferBuilder` and add the created `BufferConsumer` into one sub partition,
> then return the `BufferBuilder` for `RecordWriter` writing serialized data.
> Since we also change the `ResultPartitionWriter#addBufferConsumer` to
> `ResultPartitionWriter#requestBufferBuilder`, then another new method
> `ResultPartitionWriter#broadcastEvents` should be introduced for handling the
> case of events.
> In future it might worth further abstracting the `ResultPartitionWriter` to
> be not only related to `BufferBuilder`. We could provide `writeRecord(int
> targetIndex)` to replace `requestBufferBuilder`, then the serialization
> process could be done inside specific `ResultPartitionWriter` instance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
