zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289696435
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -615,11 +615,10 @@ private void stopTaskExecutorServices() throws Exception
{
CompletableFuture.runAsync(
() -> {
try {
- if
(!networkEnvironment.updatePartitionInfo(executionAttemptID, partitionInfo)) {
+ if
(!networkEnvironment.updatePartitionInfo(getResourceID(), executionAttemptID,
partitionInfo)) {
log.debug(
-
"Discard update for input gate partition {} of result {} in task {}. " +
+
"Discard update for input gate partition of result {} in task {}. " +
"The partition is no longer available.",
-
partitionInfo.getInputChannelDeploymentDescriptor().getConsumedPartitionId(),
Review comment:
we could still use partitionInfo.getShuffleDescriptor.getResultPartitionID
here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
