twalthr commented on a change in pull request #8521: [FLINK-12601][table] Make
the DataStream & DataSet conversion to a Table independent from Calcite
URL: https://github.com/apache/flink/pull/8521#discussion_r289729301
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/AggregateTableOperation.java
##########
@@ -53,6 +53,12 @@ public TableSchema getTableSchema() {
return tableSchema;
}
+ @Override
+ public String asSummaryString() {
+ return String.format("Aggregate: (group: %s, agg: %s)",
groupingExpressions, aggregateExpressions) +
+
TableOperationUtils.indent(this.child.asSummaryString());
Review comment:
nit: We could reduce code duplication if `String.format` and calling the
children is done in `TableOperation`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
