[
https://issues.apache.org/jira/browse/FLINK-12603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhijiang updated FLINK-12603:
-----------------------------
Description:
In order to make abstract InputGate simple for extending new implementations in
shuffle service architecture, we could remove unnecessary methods from it.
Currently InputGate#getOwningTaskName is only used for debugging log in
BarrierBuffer and StreamInputProcessor. This task name could be got from
Environment#getTaskInfo and then be passed into the constructor of
BarrierBuffer/StreamInputProcessor for use.
was:
In order to make abstract InputGate simple for extending new implementations in
shuffle service architecture, we could remove unnecessary methods from it.
Currently InputGate#getOwningTaskName is only used for debugging log in
BarrierBuffer and StreamInputProcessor. This task name could be got from
Environment#getTaskInfo and then be passed into the constructor of
BarrierBuffer/StreamInputProcessor for use.
InputGate#getPageSize is only used for BarrierBuffer constructor. We could
remove this method and the page size could also be got form task manager
configuration instead.
> Refactor InputGate interface to remove unnecessary methods
> ----------------------------------------------------------
>
> Key: FLINK-12603
> URL: https://issues.apache.org/jira/browse/FLINK-12603
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / Network
> Reporter: zhijiang
> Assignee: zhijiang
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In order to make abstract InputGate simple for extending new implementations
> in shuffle service architecture, we could remove unnecessary methods from it.
> Currently InputGate#getOwningTaskName is only used for debugging log in
> BarrierBuffer and StreamInputProcessor. This task name could be got from
> Environment#getTaskInfo and then be passed into the constructor of
> BarrierBuffer/StreamInputProcessor for use.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
