twalthr edited a comment on issue #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL URL: https://github.com/apache/flink/pull/8548#issuecomment-498167560 @danny0405 Maybe the merging happened too quickly for this PR. It is still not 100% aligned with FLIP-37. We should make sure to do that before the release. In particular: - no colon between ROW field name and type - alternative syntax `ROW(fieldName fieldType)` to be SQL compliant - support for comments in rows like `ROW<fieldName fieldType 'comment'>` - no tests for parameterized VARCHARs like `VARCHAR(100)` - alternative syntax for `VARCHAR(INT_MAX)` as `STRING` - alternative syntax for `VARBINARY(INT_MAX)` as `BYTES` - REAL is not supported Furthermore it would be great if the parser would already support all data types defined in FLIP-37 otherwise we need to check for compatibility in every corner of the stack again. Missing are (among others): CHAR, BINARY, user-defined type identifiers, MULTISET Please ensure consistency here.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
