aljoscha commented on issue #8280: [FLINK-12297]Harden ClosureCleaner to handle 
the wrapped function
URL: https://github.com/apache/flink/pull/8280#issuecomment-498187123
 
 
   I think overall the changes are good!
   
   One thing I thought about is what happens when objects that need to be 
cleaned are nested, i.e. if you have a structure like 
`OuterStaticClass.InnerStaticClass.InnerAnonymousOrLocalClass`. I think the 
current approach doesn't catch this, and checking always at the top level, as 
@StephanEwen suggested would also not catch this problem. Any thoughts?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to