aljoscha commented on a change in pull request #8280: [FLINK-12297]Harden 
ClosureCleaner to handle the wrapped function
URL: https://github.com/apache/flink/pull/8280#discussion_r289760596
 
 

 ##########
 File path: 
flink-java/src/main/java/org/apache/flink/api/java/ClosureCleaner.java
 ##########
 @@ -101,6 +132,29 @@ public static void clean(Object func, boolean 
checkSerializable) {
                }
        }
 
+       public static void clean(Object func, boolean checkSerializable) {
 
 Review comment:
   Do we strictly need the old `clean()` methods that has the default of 
"recursion". It might be more straightforward in the code to always require the 
config. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to