azagrebin commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289787348
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGateTest.java
##########
@@ -235,9 +242,8 @@ public void testUpdateChannelBeforeRequest() throws
Exception {
.buildUnknownAndSetToGate(inputGate);
// Update to a local channel and verify that no request is
triggered
- inputGate.updateInputChannel(new
InputChannelDeploymentDescriptor(
- unknown.partitionId,
- ResultPartitionLocation.createLocal()));
+ ResourceID location = ResourceID.generate();
+ inputGate.updateInputChannel(location,
createPartitionInfo(unknown.getPartitionId(), location));
Review comment:
I think the random one provides a better check for tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
