tillrohrmann commented on a change in pull request #7549: [FLINK-11403][network] Introduce ResultPartitionWithConsumableNotifier in task for notifying consumable result partition URL: https://github.com/apache/flink/pull/7549#discussion_r289869224
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/ResultPartitionWithConsumableNotifier.java ########## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.taskmanager; + +import org.apache.flink.api.common.JobID; +import org.apache.flink.runtime.deployment.ResultPartitionDeploymentDescriptor; +import org.apache.flink.runtime.io.network.api.writer.ResultPartitionWriter; +import org.apache.flink.runtime.io.network.buffer.BufferBuilder; +import org.apache.flink.runtime.io.network.buffer.BufferConsumer; +import org.apache.flink.runtime.io.network.partition.ResultPartitionConsumableNotifier; +import org.apache.flink.runtime.io.network.partition.ResultPartitionID; +import org.apache.flink.runtime.io.network.partition.ResultPartitionType; + +import java.io.IOException; +import java.util.Collection; + +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * A wrapper of result partition writer for handling the logic of consumable notification. + * + * <p>Before a consuming task can request the result, it has to be deployed. The time of deployment + * depends on the PIPELINED vs. BLOCKING characteristic of the result partition. With pipelined + * results, receivers are deployed as soon as the first buffer is added to the result partition. + * With blocking results on the other hand, receivers are deployed after the partition is finished. + */ +public class ResultPartitionWithConsumableNotifier implements ResultPartitionWriter { + + private final TaskActions taskActions; + + private final JobID jobId; + + private final ResultPartitionWriter partitionWriter; + + private final ResultPartitionConsumableNotifier partitionConsumableNotifier; + + private final ResultPartitionType partitionType; + + private boolean hasNotifiedPipelinedConsumers; + + public ResultPartitionWithConsumableNotifier( + TaskActions taskActions, + JobID jobId, + ResultPartitionWriter partitionWriter, + ResultPartitionConsumableNotifier partitionConsumableNotifier, + ResultPartitionType partitionType) { + this.taskActions = checkNotNull(taskActions); + this.jobId = checkNotNull(jobId); + this.partitionWriter = checkNotNull(partitionWriter); + this.partitionConsumableNotifier = checkNotNull(partitionConsumableNotifier); + this.partitionType = checkNotNull(partitionType); + } + + @Override + public BufferBuilder getBufferBuilder() throws IOException, InterruptedException { + return partitionWriter.getBufferBuilder(); + } + + @Override + public ResultPartitionID getPartitionId() { + return partitionWriter.getPartitionId(); + } + + @Override + public int getNumberOfSubpartitions() { + return partitionWriter.getNumberOfSubpartitions(); + } + + @Override + public int getNumTargetKeyGroups() { + return partitionWriter.getNumTargetKeyGroups(); + } + + @Override + public void setup() throws IOException { + partitionWriter.setup(); + } + + @Override + public boolean addBufferConsumer(BufferConsumer bufferConsumer, int subpartitionIndex) throws IOException { + boolean success = partitionWriter.addBufferConsumer(bufferConsumer, subpartitionIndex); + if (success) { + notifyPipelinedConsumers(); + } + + return success; + } + + @Override + public void flushAll() { + partitionWriter.flushAll(); + } + + @Override + public void flush(int subpartitionIndex) { + partitionWriter.flush(subpartitionIndex); + } + + @Override + public void finish() throws IOException { + partitionWriter.finish(); + + notifyPipelinedConsumers(); + } + + @Override + public void fail(Throwable throwable) { + partitionWriter.fail(throwable); + } + + @Override + public void close() throws Exception { + partitionWriter.close(); + } + + /** + * Notifies pipelined consumers of this result partition once. + * + * <p>For PIPELINED {@link org.apache.flink.runtime.io.network.partition.ResultPartitionType}s, + * this will trigger the deployment of consuming tasks after the first buffer has been added. + */ + private void notifyPipelinedConsumers() { + if (!hasNotifiedPipelinedConsumers && partitionType.isPipelined()) { Review comment: can't we check `partitionType.isPipelined` when we create an instance of this class? That way we would not have to make this case distinction here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
