pnowojski commented on a change in pull request #8320:
[FLINK-12201][network,metrics] Introduce InputGateWithMetrics in Task to
increment numBytesIn metric
URL: https://github.com/apache/flink/pull/8320#discussion_r290172240
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/benchmark/StreamNetworkBenchmarkEnvironment.java
##########
@@ -270,4 +266,18 @@ private InputGateDeploymentDescriptor
createInputGateDeploymentDescriptor(
consumedSubpartitionIndex,
channelDescriptors);
}
+
+ private InputGate createInputGateWithMetrics(
+ SingleInputGateFactory gateFactory,
+ InputGateDeploymentDescriptor gateDescriptor,
+ int channelIndex) {
+
+ final SingleInputGate singleGate = gateFactory.create(
+ "receiving task[" + channelIndex + "]",
+ gateDescriptor,
+ SingleInputGateBuilder.NO_OP_PRODUCER_CHECKER,
+
InputChannelTestUtils.newUnregisteredInputChannelMetrics());
+
+ return new InputGateWithMetrics(singleGate, new
SimpleCounter());
Review comment:
Ok, I understand. In that case maybe we could consider some another layer of
factory/builder? One that takes a concrete NetworkEnvironment and creates
InputGates wrapped with metrics? I'm not sure if that's worth, but you see the
code duplication here? And the risks that if those two code parts will drift
apart, the benchmarks might become inaccurate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
