GJL commented on a change in pull request #8486: [FLINK-12372] [runtime] implement ExecutionSlotAllocator URL: https://github.com/apache/flink/pull/8486#discussion_r290328242
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/ExecutionVertexSchedulingRequirements.java ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.scheduler; + +import org.apache.flink.runtime.clusterframework.types.AllocationID; +import org.apache.flink.runtime.clusterframework.types.ResourceProfile; +import org.apache.flink.runtime.executiongraph.ExecutionVertex; +import org.apache.flink.runtime.instance.SlotSharingGroupId; +import org.apache.flink.runtime.jobmanager.scheduler.CoLocationConstraint; +import org.apache.flink.runtime.scheduler.strategy.ExecutionVertexID; +import org.apache.flink.runtime.taskmanager.TaskManagerLocation; + +import java.util.Collection; + +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * The requirements for scheduling a {@link ExecutionVertex}. + */ +public class ExecutionVertexSchedulingRequirements { + + private final ExecutionVertexID executionVertexId; + + private final AllocationID previousAllocationId; + + private final ResourceProfile resourceProfile; + + private final SlotSharingGroupId slotSharingGroupId; + + private final CoLocationConstraint coLocationConstraint; + + private final Collection<TaskManagerLocation> preferredLocations; + + public ExecutionVertexSchedulingRequirements( Review comment: A constructor this big would benefit from the builder pattern, e.g., ``` /** * Builder for {@link ExecutionVertexSchedulingRequirements}. */ public static class Builder { private ExecutionVertexID executionVertexId; private AllocationID previousAllocationId; private ResourceProfile resourceProfile = ResourceProfile.UNKNOWN; private SlotSharingGroupId slotSharingGroupId; private CoLocationConstraint coLocationConstraint; private Collection<TaskManagerLocation> preferredLocations = Collections.emptyList(); public Builder withExecutionVertexId(final ExecutionVertexID executionVertexId) { this.executionVertexId = executionVertexId; return this; } public Builder withPreviousAllocationId(final AllocationID previousAllocationId) { this.previousAllocationId = previousAllocationId; return this; } public Builder withResourceProfile(final ResourceProfile resourceProfile) { this.resourceProfile = resourceProfile; return this; } public Builder withSlotSharingGroupId(final SlotSharingGroupId slotSharingGroupId) { this.slotSharingGroupId = slotSharingGroupId; return this; } public Builder withCoLocationConstraint(final CoLocationConstraint coLocationConstraint) { this.coLocationConstraint = coLocationConstraint; return this; } public Builder withPreferredLocations(final Collection<TaskManagerLocation> preferredLocations) { this.preferredLocations = preferredLocations; return this; } public ExecutionVertexSchedulingRequirements build() { return new ExecutionVertexSchedulingRequirements( executionVertexId, previousAllocationId, resourceProfile, slotSharingGroupId, coLocationConstraint, preferredLocations); } } ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
