zhuzhurk edited a comment on issue #8620: [FLINK-12643] [runtime] Implement ExecutionGraph to FailoverTopology Adapter URL: https://github.com/apache/flink/pull/8620#issuecomment-498995343 > Thanks @zhuzhurk for this PR, I think some variable types could be interface rather than implementation, since the former is more flexible. Please let me know what you think. Thanks Bo for reviewing this change! I have once thought of the same thing. Finally I chose to use implemented classes. In my mind, the DefaultFailover* is a set of related components, which means DefaultFailoverTopology must consist of DefaultFailoverVertex(es), and DefaultFailoverVertex are intended to be connected by DefaultFailoverEdge(s). Making it flexible by mixing different implementations together seems strange some times, like connecting DefaultFailoverVertex(es) with LegacyFailoverVertex or so.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
