zentol commented on a change in pull request #8563: [FLINK-12602][travis]
Correct the flink pom `artifactId` config and s…
URL: https://github.com/apache/flink/pull/8563#discussion_r290665997
##########
File path: flink-connectors/flink-sql-connector-kafka-0.10/pom.xml
##########
@@ -41,6 +41,14 @@ under the License.
<artifactId>flink-connector-kafka-0.10_${scala.binary.version}</artifactId>
<version>${project.version}</version>
</dependency>
+ <!-- Due to the scope of `provided` transitive dependencies
problem,
Review comment:
this looks hacky; why can't we search the pom for dependencies with a
scala-suffix instead? Shouldn't this be as simple as adding `*:*_2.1*:*` as an
artifact pattern to `-Dincludes`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
