knaufk commented on a change in pull request #8539: [FLINK-12617] [container]
StandaloneJobClusterEntrypoint defaults to random JobID for non-HA setups
URL: https://github.com/apache/flink/pull/8539#discussion_r290741312
##########
File path:
flink-container/src/main/java/org/apache/flink/container/entrypoint/ClassPathJobGraphRetriever.java
##########
@@ -63,8 +63,7 @@
@Nonnull
private final String[] programArguments;
- @Nullable
- private final String jobClassName;
+ private final Optional<String> jobClassName;
Review comment:
Done. I originally did these changes, because I did not want to mix
`@Nullable` xor `Optional` for fields.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
