azagrebin commented on a change in pull request #8630: [FLINK-12667][runtime]
Add JobID to TaskExecutorGateway#releasePartitions
URL: https://github.com/apache/flink/pull/8630#discussion_r290839184
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -641,7 +641,7 @@ private void stopTaskExecutorServices() throws Exception {
}
@Override
- public void releasePartitions(Collection<ResultPartitionID>
partitionIds) {
+ public void releasePartitions(JobID jobId,
Collection<ResultPartitionID> partitionIds) {
Review comment:
a bit weird that we will leave `jobId` here unused, is the future change
that needs it going to be so big?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
