xuefuz commented on issue #8616: [FLINK-12718][hive] allow users to specify hive-site.xml location to configure hive metastore client in HiveCatalog URL: https://github.com/apache/flink/pull/8616#issuecomment-499201240 I think a builder might be an overkill. We just need to provide a couple of basic constructors and take care of nulls. Looking at the PR I see we still force user to provide a url for hive-site location. To me that's optional. If user doesn't provide it (or provide null for it), we should just instantiate HiveConf, which takes whatever from the environment. Did I miss anything?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
