bowenli86 commented on a change in pull request #8610: [FLINK-12715][hive]
Hive-1.2.1 build is broken
URL: https://github.com/apache/flink/pull/8610#discussion_r291010920
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV1.java
##########
@@ -79,4 +85,14 @@ public Function getFunction(IMetaStoreClient client, String
dbName, String funct
throw e;
}
}
+
+ @Override
+ public boolean moveToTrash(FileSystem fs, Path path, Configuration
conf, boolean purge) throws IOException {
Review comment:
I see, can we add a comment to the interface's param explaining the flag
only works for hive 2 (or 2.1.x, or any version it works)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
