zhijiangW commented on a change in pull request #8485: [FLINK-12555] Introduce
an encapsulated metric group layout for shuffle API
URL: https://github.com/apache/flink/pull/8485#discussion_r291012707
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
##########
@@ -69,7 +70,13 @@
private static final Logger LOG =
LoggerFactory.getLogger(NetworkEnvironment.class);
- private static final String METRIC_GROUP_NETWORK = "Network";
+ @SuppressWarnings("DeprecatedIsStillUsed")
+ @Deprecated private static final String METRIC_GROUP_NETWORK_DEPRECATED
= "Network";
+ private static final String METRIC_GROUP_SHUFFLE = "Shuffle";
+ private static final String METRIC_GROUP_NETTY = "Netty";
+ private static final String METRIC_GROUP_OUTPUT = "Output";
+ private static final String METRIC_GROUP_INPUT = "Input";
+ private static final String METRIC_GROUP_BUFFERS = "Buffers";
Review comment:
There are already too many metrics here and it seems hard to distinguish
them if not focusing on the below implementations. Could we give some comments
or other forms to clearly know the architecture of these metrics?
At least to distinguish the task-level metrics and global metrics.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
