[
https://issues.apache.org/jira/browse/FLINK-12737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857339#comment-16857339
]
Dawid Wysakowicz edited comment on FLINK-12737 at 6/6/19 6:24 AM:
------------------------------------------------------------------
`Table#insertInto` calls internal method of `TableEnvironment`. What I am
suggesting is to make this private method public to softer the dependency on
internal implementation.
This is also a cleaner design, I think cause right the `Table` pulls
unnecessary dependency on the runtime class which is the `TableEnvironment`.
was (Author: dawidwys):
`Table#insertInto` calls internal method of `TableEnvironment`. What I am
suggesting is to make this private method public to softer the dependency on
internal implementation.
> Loosen Table class dependencies
> -------------------------------
>
> Key: FLINK-12737
> URL: https://issues.apache.org/jira/browse/FLINK-12737
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / API, Table SQL / Legacy Planner
> Reporter: Dawid Wysakowicz
> Assignee: Dawid Wysakowicz
> Priority: Major
> Fix For: 1.9.0
>
>
> The aim of this task is to remove dependencies on actual implementation of
> {{TableEnvironment}}. This includes:
> * drop generating unique attribute generation (it sufficient to index
> aggregates within a single operation)
> * make the transformation from {{Table}} on the caller side rather than on
> the callee (a.k.a remove getRelNode)
> * Add {{insertInto}} method to {{TableEnvironment}}
> Additionally move the TemporalTableFunctionImpl to api-java module.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
