tianchen92 commented on a change in pull request #8624: [FLINK-10932]Initial 
flink-kubernetes module with empty implementation
URL: https://github.com/apache/flink/pull/8624#discussion_r291085603
 
 

 ##########
 File path: flink-kubernetes/pom.xml
 ##########
 @@ -0,0 +1,104 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+  http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0";
+                xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+                xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+       <modelVersion>4.0.0</modelVersion>
+       <parent>
+               <groupId>org.apache.flink</groupId>
+               <artifactId>flink-parent</artifactId>
+               <version>1.9-SNAPSHOT</version>
+               <relativePath>..</relativePath>
+       </parent>
+
+       <artifactId>flink-kubernetes_${scala.binary.version}</artifactId>
+       <name>flink-kubernetes</name>
+       <packaging>jar</packaging>
+
+       <properties>
+               <kubernetes.version>1.0.1</kubernetes.version>
+       </properties>
+
+       <dependencies>
+
+               <!-- set all Flink dependencies to provided, so they and their 
transitive  -->
+               <!-- dependencies do not get promoted to direct dependencies 
during shading -->
+
+               <dependency>
+                       <groupId>org.apache.flink</groupId>
+                       
<artifactId>flink-clients_${scala.binary.version}</artifactId>
+                       <version>${project.version}</version>
+                       <scope>provided</scope>
+               </dependency>
+
+               <dependency>
+                       <groupId>org.apache.flink</groupId>
+                       
<artifactId>flink-runtime_${scala.binary.version}</artifactId>
+                       <version>${project.version}</version>
+                       <scope>provided</scope>
+               </dependency>
+
+               <dependency>
+                       <groupId>io.fabric8</groupId>
+                       <artifactId>kubernetes-client</artifactId>
+                       <version>4.2.0</version>
+               </dependency>
+
+               <!-- test dependencies -->
+
+               <dependency>
+                       <groupId>io.fabric8</groupId>
+                       <artifactId>kubernetes-server-mock</artifactId>
+                       <version>4.2.0</version>
+                       <scope>test</scope>
+                       <exclusions>
+                               <exclusion>
+                                       <groupId>com.squareup.okhttp3</groupId>
+                                       <artifactId>okhttp</artifactId>
+                               </exclusion>
+                       </exclusions>
+               </dependency>
+
+               <dependency>
+                       <groupId>org.apache.flink</groupId>
+                       <artifactId>flink-test-utils-junit</artifactId>
+               </dependency>
+
+       </dependencies>
+
+       <dependencyManagement>
+               <dependencies>
+                       <dependency>
+                               <groupId>com.fasterxml.jackson.core</groupId>
+                               <artifactId>jackson-core</artifactId>
+                               <version>${jackson.version}</version>
+                       </dependency>
+                       <dependency>
+                               <groupId>com.fasterxml.jackson.core</groupId>
+                               <artifactId>jackson-databind</artifactId>
+                               <version>${jackson.version}</version>
+                       </dependency>
+                       <dependency>
+                               <groupId>com.fasterxml.jackson.core</groupId>
+                               <artifactId>jackson-annotations</artifactId>
+                               <version>${jackson.version}</version>
+                       </dependency>
+               </dependencies>
+       </dependencyManagement>
 
 Review comment:
   Thanks for your quick reply, I wonder if we remove this, the error below 
will still occur:
   
![image](https://user-images.githubusercontent.com/25814127/59019890-6cd89900-887b-11e9-8504-1b534699f149.png)
   
   Seems dependencyManagement allows to specify the versions of artifacts to be 
used when they are encountered in transitive dependencies or in dependencies 
where no version has been specified and this multi versions problem can be 
solved.
   
   Or any better solutions for the dependency error mentioned above?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to