zentol commented on a change in pull request #8474: [FLINK-12409][python] Adds 
from_elements in TableEnvironment
URL: https://github.com/apache/flink/pull/8474#discussion_r291130286
 
 

 ##########
 File path: NOTICE-binary
 ##########
 @@ -5866,3 +5866,42 @@ This project bundles the following dependencies under 
the Apache Software Licens
 
 Apache HttpClient
 Copyright 1999-2017 The Apache Software Foundation
+
+// ------------------------------------------------------------------
+// NOTICE file corresponding to the section 4d of The Apache License,
+// Version 2.0, in this case for Apache Flink
+// ------------------------------------------------------------------
+
+Apache Flink
+Copyright 2006-2019 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+flink-python
 
 Review comment:
   well you could just call it flink-api-python or something, that's doesn't 
seem that inappropriate.
   
   I don't believe we should be re-using artifactIds between releases if they 
are fundamentally different artifacts; it is for the same reason that we have 
not added another `flink-ml` module but named it `flink-ml-parent` instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to