NicoK commented on issue #7368: [FLINK-10742][network] Let Netty use Flink's buffers directly in credit-based mode URL: https://github.com/apache/flink/pull/7368#issuecomment-499475723 Hi @gaoyunhaii and @pnowojski, I took the liberty to rebase this PR on top of the latest master (see https://github.com/NicoK/flink/tree/f10742) and run our benchmarks. Unfortunately, changes are not really visible there (still, the reduced memory is also an argument for this PR). Slight improvements, maybe also in the error... ``` Benchmark Score±Error (master vs. PR) networkBroadcastThroughput 817 ± 24 vs. 832 ± 17 networkThroughput, 100,100ms 65096 ±2273 vs. 65451 ±1020 networkThroughput, 100,100ms,SSL 16432 ± 701 vs. 16748 ± 448 networkThroughput, 1000,1ms 41128 ± 903 vs. 42872 ± 934 networkThroughput, 1000,100ms 46166 ±1343 vs. 46304 ±1938 networkThroughput, 1000,100ms,SSL 13677 ± 173 vs. 13801 ± 196 ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
