Github user andralungu commented on the pull request:

    https://github.com/apache/flink/pull/1105#issuecomment-139820404
  
    If it's okay with you, I'd like to see what @vasia has to say about adding 
the Triangle Count example from the DataSet API +  a reduce as a library 
method. IMO, it's a better addition, but for some reason, we preferred the 
Pregel/GSA implementations at a certain point (it was because in my thesis, I 
take Pregel as a baseline). 
    
    Also the generic K instead of Long makes perfect sense. However, if we 
decide to change it, I'll have to open a JIRA to revise the entire set of 
library methods because apart from PageRank, I think they all restrict 
themselves to one common key type. I would be kind of scared of type erasure in 
the K implements Key case :-S 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to