azagrebin commented on issue #8485: [FLINK-12555] Introduce an encapsulated 
metric group layout for shuffle API
URL: https://github.com/apache/flink/pull/8485#issuecomment-499913877
 
 
   Thanks for the reviews @zentol @zhijiangW, I've addressed comments
   This PR is now based on #8608 which I think needs to be merged first.
   While rebasing, I introduced a `ShuffleIOOwnerContext` which is now created 
by Task using `ShuffleEnvironment.createShuffleIOOwnerContext` before creating 
partitions/gates. `NettyShuffleEnvironment.createShuffleIOOwnerContext` also 
creates netty metric groups, only once.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to