becketqin commented on a change in pull request #8653: [FLINK-10455][Connectors/Kafka] Ensure all the KafkaProducers are recycled when FlinkKafk… URL: https://github.com/apache/flink/pull/8653#discussion_r291856564
########## File path: flink-connectors/flink-connector-kafka/src/test/resources/log4j-test.properties ########## @@ -16,15 +16,14 @@ # limitations under the License. ################################################################################ -log4j.rootLogger=INFO, testlogger +log4j.rootLogger=OFF, testlogger Review comment: In general, unit test should run silently without log4j logs by default. Otherwise it will pollute the screen and slow down the tests. Failures should be reported via the testing framework such as JUnit/ TestNG. If detail logs are needed for debugging, one should manually turn on the log4j logs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
