JingsongLi commented on a change in pull request #8435:
[FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in
blink
URL: https://github.com/apache/flink/pull/8435#discussion_r291888066
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/schema/GenericRelDataType.scala
##########
@@ -55,4 +57,8 @@ class GenericRelDataType(
override def hashCode(): Int = {
genericType.hashCode()
}
+
+ override def generateTypeString(sb: lang.StringBuilder, withDetail:
Boolean): Unit = {
Review comment:
Now we delete `ArrayRelDataType` and use `ArraySqlType` and etc...
NOTE: `equals` of `ArraySqlType` is:
```
@Override public boolean equals(Object obj) {
if (obj instanceof RelDataTypeImpl) {
final RelDataTypeImpl that = (RelDataTypeImpl) obj;
return this.digest.equals(that.digest);
}
return false;
}
```
So we must need override `generateTypeString` all calcite extended type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
