zhijiangW commented on a change in pull request #8608: [FLINK-11392][network]
Introduce ShuffleEnvironment interface
URL: https://github.com/apache/flink/pull/8608#discussion_r291917946
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesConfiguration.java
##########
@@ -196,17 +236,22 @@ RetryingRegistrationConfiguration
getRetryingRegistrationConfiguration() {
* sanity check them.
*
* @param configuration The configuration.
- * @param maxJvmHeapMemory The maximum JVM heap size, in bytes.
+ * @param resourceID resource ID of the task manager
* @param remoteAddress identifying the IP address under which the
TaskManager will be accessible
- * @param localCommunication True, to skip initializing the network
stack.
- * Use only in cases where only
one task manager runs.
- * @return TaskExecutorConfiguration that wrappers
InstanceConnectionInfo, NetworkEnvironmentConfiguration, etc.
+ * @param freeHeapMemoryWithDefrag an estimate of the size of the free
heap memory
+ * @param maxJvmHeapMemory the maximum JVM heap size
+ * @param localCommunicationOnly True if only local communication is
possible.
+ * Use only in cases where only one task
manager runs.
+ *
+ * @return TaskExecutorConfiguration that wrappers
InstanceConnectionInfo, etc.
Review comment:
return `TaskManagerServicesConfiguration`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
