[ 
https://issues.apache.org/jira/browse/FLINK-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743285#comment-14743285
 ] 

ASF GitHub Bot commented on FLINK-2641:
---------------------------------------

Github user mxm commented on the pull request:

    https://github.com/apache/flink/pull/1125#issuecomment-140022781
  
    In addition to the discussion in the JIRA, I had to change the way the 
network memory is configured because otherwise I cannot calculate the direct 
memory size correctly. The default network buffer size is not easy to get in 
the startup scripts without also putting it in the config. Besides that, I 
think it will be much easier for users to configure the network buffer size 
using an absolute value rather than some obscure numberOfNetworkBuffers.
    
    > We have to be clear and careful with the term managed memory also, as the 
regular JVM heap is managed memory (managed by the JVM / GC) as opposed to the 
unmanaged memory in a C++ program.
    
    In Flink, we always use the term managed memory to refer to our own memory 
management. So I think it makes sense to stick to that term. The former name 
`taskmanager.memory.size` was not clearer in any way because one would think 
that this refers to the total memory size rather than the Flink managed memory 
size.


> Integrate the off-heap memory configuration with the TaskManager start script
> -----------------------------------------------------------------------------
>
>                 Key: FLINK-2641
>                 URL: https://issues.apache.org/jira/browse/FLINK-2641
>             Project: Flink
>          Issue Type: New Feature
>          Components: Start-Stop Scripts
>    Affects Versions: 0.10
>            Reporter: Stephan Ewen
>            Assignee: Maximilian Michels
>             Fix For: 0.10
>
>
> The TaskManager start script needs to adjust the {{-Xmx}}, {{-Xms}}, and 
> {{-XX:MaxDirectMemorySize}} parameters according to the off-heap memory 
> settings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to