JingsongLi commented on a change in pull request #8530:
[FLINK-12611][table-planner-blink] Make time indicator nullable in blink
URL: https://github.com/apache/flink/pull/8530#discussion_r291940225
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/functions/sql/ProctimeSqlFunction.java
##########
@@ -37,16 +34,15 @@ public ProctimeSqlFunction() {
super(
"PROCTIME",
SqlKind.OTHER_FUNCTION,
- ReturnTypes.explicit(new
ProctimeRelProtoDataType()),
+ ReturnTypes.explicit(factory ->
Review comment:
Previously set to false causes sorts of inexplicable errors in
`LookupJoinTest`.
The fundamental reason is that:
`TimeIndicatorRelDataType` assigns `isNullable` and overrides `equals`, but
`BasicSqlType` do `computeDigest` at the constructor, so this leads to the
inconsistency between `equals` and `Digest`, which leads to a variety of
problems.
Fixed it in ff7c1e7
(Looks like `GenericRelDataType` has same problem.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
