zhijiangW commented on a change in pull request #8485: [FLINK-12555] Introduce
an encapsulated metric group layout for shuffle API
URL: https://github.com/apache/flink/pull/8485#discussion_r292259702
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -359,21 +360,13 @@ public Task(
final String taskNameWithSubtaskAndId = taskNameWithSubtask + "
(" + executionId + ')';
Review comment:
I could agree your way to keep it. :)
My previous concern is that `taskNameWithSubtaskAndId` was used in many
places before, so it worths defining a local var. Now it is only used in one
place and we could reduce one line to make task constructor short to remove it.
Another small consideration is avoiding final issue as above mentioned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
