wuchong commented on a change in pull request #8629:
[FLINK-12088][table-runtime-blink] Introduce unbounded streaming
inner/left/right/full join operator
URL: https://github.com/apache/flink/pull/8629#discussion_r292271043
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/nodes/physical/stream/StreamExecJoin.scala
##########
@@ -104,6 +110,14 @@ class StreamExecJoin(
new StreamExecJoin(cluster, traitSet, left, right, conditionExpr, joinType)
}
+
+ override def explainTerms(pw: RelWriter): RelWriter = {
+ super
+ .explainTerms(pw)
+ .item("leftInputSpec", analyzeJoinInput(left))
Review comment:
I think it would be better to have it, because it will effect performance a
lot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services