c4emmmm commented on a change in pull request #8632: [FLINK-12744][ml] add
shared params in ml package
URL: https://github.com/apache/flink/pull/8632#discussion_r292293350
##########
File path: flink-ml-parent/pom.xml
##########
@@ -35,5 +35,6 @@ under the License.
<modules>
<module>flink-ml-api</module>
+ <module>flink-ml</module>
Review comment:
I think here should be flink-ml-lib and the directory should also be
flink-ml-lib rather than flink-ml. It's the artifact id defined in
flink-ml-parent/flink-ml/pom.xml and is also the determined module name for ml
libraries in FLIP-39.
Maybe all classes in this and related 2 PRs should also be moved from
org.apache.flink.ml to org.apache.flink.ml.lib package.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
