aljoscha commented on a change in pull request #8685: [FLINK-12799][table] 
Improve expression based TableSchema extraction from DataStream/DataSet
URL: https://github.com/apache/flink/pull/8685#discussion_r292463994
 
 

 ##########
 File path: 
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/typeutils/FieldInfoUtils.java
 ##########
 @@ -180,7 +278,7 @@ public static boolean 
isReferenceByPosition(CompositeType<?> ct, Expression[] fi
                }
 
 Review comment:
   Whats the story behind `ATOMIC_FIELD_NAME` here? It's more for my education 
than about this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to