XuPingyong commented on a change in pull request #8690:
[FLINK-12801][table-planner-blink] set parallelism for batch SQL
URL: https://github.com/apache/flink/pull/8690#discussion_r292531978
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/nodes/physical/batch/BatchExecSortWindowAggregate.scala
##########
@@ -96,8 +96,4 @@ class BatchExecSortWindowAggregate(
val aggregateNamePrefix = if (isMerge) "Global" else "Complete"
aggregateNamePrefix + "WindowSortAggregateBatchExec"
}
-
- override def getParallelism(input: StreamTransformation[BaseRow], conf:
TableConfig): Int = {
- if (isFinal && grouping.length == 0) 1 else input.getParallelism
Review comment:
> How do you set parallelism 1 in this case? Maybe you can add some comments
in `BatchShuffleStageParallelismCalculator`?
I add comments in BatchFinalParallelismSetter, as its parallelism is set to
1 depends on the global exchange.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
