aljoscha commented on a change in pull request #8678: [FLINK-12708][table] 
Introduce new source and sink interfaces to make Blink runner work
URL: https://github.com/apache/flink/pull/8678#discussion_r292520062
 
 

 ##########
 File path: 
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/StreamTableEnvImpl.scala
 ##########
 @@ -93,6 +93,10 @@ abstract class StreamTableEnvImpl(
                 s"environment. But is: ${execEnv.getStreamTimeCharacteristic}")
         }
 
+      case streamTableSource: StreamTableSource[_] if 
streamTableSource.isBounded =>
 
 Review comment:
   Is this check necessary? I think the Flink planner probably can execute the 
source just like that.
   
   I don't know the details, so I might be wrong, of course.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to