lirui-apache commented on a change in pull request #8614: [FLINK-12727][hive]
Make HiveTableOutputFormat support writing partitioned table
URL: https://github.com/apache/flink/pull/8614#discussion_r292725038
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##########
@@ -120,8 +119,7 @@ public HiveCatalog(String catalogName, @Nullable String
defaultDatabase, @Nullab
createHiveConf(hiveSiteUrl));
}
- @VisibleForTesting
- protected HiveCatalog(String catalogName, String defaultDatabase,
HiveConf hiveConf) {
+ public HiveCatalog(String catalogName, String defaultDatabase, HiveConf
hiveConf) {
Review comment:
Actually I think `HiveCatalog#instantiateHivePartition()` is more "internal"
than a constructor. But I'm fine with either way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
