liyafan82 commented on a change in pull request #8682:
[FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce
conversion overhead to blink
URL: https://github.com/apache/flink/pull/8682#discussion_r292733061
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/types/InternalSerializers.java
##########
@@ -71,10 +75,12 @@ public static TypeSerializer create(LogicalType type,
ExecutionConfig config) {
DecimalType decimalType = (DecimalType) type;
return new
DecimalSerializer(decimalType.getPrecision(), decimalType.getScale());
case ARRAY:
- return BinaryArraySerializer.INSTANCE;
+ return new BaseArraySerializer(((ArrayType)
type).getElementType(), config);
Review comment:
Each time requires creating a new serializer. Does it cause performance
degrade?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
