zhijiangW commented on a change in pull request #8687: 
[FLINK-12612][coordination] Track stored partition on the TaskExecutor 
URL: https://github.com/apache/flink/pull/8687#discussion_r292771583
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
 ##########
 @@ -283,7 +283,7 @@ public Task(
                int targetSlotNumber,
                MemoryManager memManager,
                IOManager ioManager,
-               ShuffleEnvironment<?, ?> shuffleEnvironment,
+               JobAwareShuffleEnvironment<?, ?> shuffleEnvironment,
 
 Review comment:
   We could still reference `ShuffleEnvironment` here if making 
`JobAwareShuffleEnvironment` extend `ShuffleEnvironment` as mentioned above.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to