[
https://issues.apache.org/jira/browse/FLINK-2667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743859#comment-14743859
]
Robert Metzger edited comment on FLINK-2667 at 9/14/15 5:21 PM:
----------------------------------------------------------------
- For those changes where you change from {{\*.mb}} to {{\*.memory}}: I really
like when configuration values contain the unit. This makes it clear for both
developers writing code and users setting the values.
Why aren't we following a soft approach for the configuration parameter
changes: in the next release (0.10) support both keys, and log a deprecation
warning for each used old config parameter. In the next release (0.11), we
completely remove the old config parameters?
was (Author: rmetzger):
- For those changes where you change from {{*.mb} to {{*.memory}}: I really
like when configuration values contain the unit. This makes it clear for both
developers writing code and users setting the values.
Why aren't we following a soft approach for the configuration parameter
changes: in the next release (0.10) support both keys, and log a deprecation
warning for each used old config parameter. In the next release (0.11), we
completely remove the old config parameters?
> Rework configuration parameters
> -------------------------------
>
> Key: FLINK-2667
> URL: https://issues.apache.org/jira/browse/FLINK-2667
> Project: Flink
> Issue Type: Improvement
> Components: Start-Stop Scripts
> Affects Versions: 0.10
> Reporter: Maximilian Michels
> Fix For: 0.10
>
>
> In the course of FLINK-2641, we came up with some changes to make the
> configuration parameters more meaningful and self-explanatory. Some concerns
> about backwards-compatibility were raised in the associated pull request:
> https://github.com/apache/flink/pull/1125. That's why I decided to delay
> those changes.
> Here are the changes to the configuration which I would like to propose:
> {{taskmanager.memory.size}} --> {{taskmanager.memory.managed}}
> {{taskmanager.memory.fraction}} --> {{taskmanager.memory.managed.fraction}}
> {{taskmanager.heap.mb}} --> {{taskmanager.memory}}
> (Change its meaning to combined JVM heap + off-heap memory)
> {{jobmanager.heap.mb}} --> {{jobmanager.memory}}
> {{taskmanager.network.numberOfBuffers}} --> {{taskmanager.network.memory}}
> (Specify the network size in terms of space and not in terms of the number of
> buffers)
> I think those changes would make configuration easier and improve the overall
> user experience of Flink. The drawback is that it requires some users to
> update their config files. I believe the negative impact will be very little
> because only two of the changed parameters are present in the default config.
> Adapting to these new parameters should be easy because they make a lot more
> sense but I wanted to put this up for debate.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
