tillrohrmann commented on a change in pull request #7227: [FLINK-11059]
[runtime] do not add releasing failed slot to free slots
URL: https://github.com/apache/flink/pull/7227#discussion_r292889501
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolTest.java
##########
@@ -599,18 +603,17 @@ public void testCheckIdleSlot() throws Exception {
}
/**
- * Tests that idle slots which cannot be released are only recycled if
the owning {@link TaskExecutor}
- * is still registered at the {@link SlotPoolImpl}. See FLINK-9047.
+ * Tests that idle slots which cannot be released will retry until the
exception should be ignored. See FLINK-11059.
*/
@Test
public void testReleasingIdleSlotFailed() throws Exception {
Review comment:
The test is no longer correct. It assumes that
`TaskExecutorGateway#freeSlot` is called twice whereas it should only be called
once.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
