StefanRRichter commented on a change in pull request #8322: [FLINK-12364]
Introduce a CheckpointFailureManager to centralized manage checkpoint failure
URL: https://github.com/apache/flink/pull/8322#discussion_r292939539
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -439,6 +436,10 @@ public boolean triggerCheckpoint(long timestamp, boolean
isPeriodic) {
triggerCheckpoint(timestamp, checkpointProperties,
null, isPeriodic, false);
return true;
} catch (CheckpointException e) {
+ long latestGeneratedCheckpointId =
getCheckpointIdCounter().get();
Review comment:
Can you explain why we actually need to get the latest id again from the
counter and cannot just remember it in a field when we do `checkpointID =
checkpointIdCounter.getAndIncrement();` in `triggerCheckpoint(...)` as part of
and `checkpointIdCounter.setCount(nextCheckpointId);` in `restore(...)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
