gaoyunhaii commented on a change in pull request #8687:
[FLINK-12612][coordination] Track stored partition on the TaskExecutor
URL: https://github.com/apache/flink/pull/8687#discussion_r293197764
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/ResultPartitionManagerTest.java
##########
@@ -60,4 +61,26 @@ public void testCreateViewForRegisteredPartition() throws
Exception {
partitionManager.registerResultPartition(partition);
partitionManager.createSubpartitionView(partition.getPartitionId(), 0, new
NoOpBufferAvailablityListener());
}
+
+ @Test
+ public void testExternallyManagedPartitionReleaseIfFlagDisabled() {
Review comment:
I think it would be better to have a common utility method with a parameters
indicating whether to release externally managed partitions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
